Re: [PATCH 2/2] i3c/master: add the mipi-i3c-hci driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nicolas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v5.8 next-20200814]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicolas-Pitre/MIPI-I3c-HCI-Host-Controller-Interface-driver/20200814-115156
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-randconfig-s021-20200816 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-168-g9554805c-dirty
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)

>> drivers/i3c/master/mipi-i3c-hci/ext_caps.c:153:26: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void *vendor_data @@     got void [noderef] __iomem *base @@
>> drivers/i3c/master/mipi-i3c-hci/ext_caps.c:153:26: sparse:     expected void *vendor_data
>> drivers/i3c/master/mipi-i3c-hci/ext_caps.c:153:26: sparse:     got void [noderef] __iomem *base
--
>> drivers/i3c/master/mipi-i3c-hci/pio.c:248:22: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] data @@     got restricted __le32 [usertype] @@
>> drivers/i3c/master/mipi-i3c-hci/pio.c:248:22: sparse:     expected unsigned int [usertype] data
>> drivers/i3c/master/mipi-i3c-hci/pio.c:248:22: sparse:     got restricted __le32 [usertype]
>> drivers/i3c/master/mipi-i3c-hci/pio.c:407:35: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [assigned] [usertype] last_word @@     got restricted __le32 [usertype] @@
>> drivers/i3c/master/mipi-i3c-hci/pio.c:407:35: sparse:     expected unsigned int [assigned] [usertype] last_word
   drivers/i3c/master/mipi-i3c-hci/pio.c:407:35: sparse:     got restricted __le32 [usertype]
>> drivers/i3c/master/mipi-i3c-hci/pio.c:699:22: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [assigned] [usertype] data @@     got restricted __le32 [usertype] @@
>> drivers/i3c/master/mipi-i3c-hci/pio.c:699:22: sparse:     expected unsigned int [assigned] [usertype] data
   drivers/i3c/master/mipi-i3c-hci/pio.c:699:22: sparse:     got restricted __le32 [usertype]
--
>> drivers/i3c/master/mipi-i3c-hci/core.c:614:60: sparse: sparse: Using plain integer as NULL pointer
   drivers/i3c/master/mipi-i3c-hci/core.c:622:60: sparse: sparse: Using plain integer as NULL pointer
   drivers/i3c/master/mipi-i3c-hci/core.c:630:60: sparse: sparse: Using plain integer as NULL pointer
   drivers/i3c/master/mipi-i3c-hci/core.c:635:60: sparse: sparse: Using plain integer as NULL pointer
   drivers/i3c/master/mipi-i3c-hci/core.c:640:64: sparse: sparse: Using plain integer as NULL pointer

vim +153 drivers/i3c/master/mipi-i3c-hci/ext_caps.c

   150	
   151	static int hci_extcap_vendor_NXP(struct i3c_hci *hci, void __iomem *base)
   152	{
 > 153		hci->vendor_data = base;
   154		INFO("Build Date Info = %#x", readl(base + 1*4));
   155		/* reset the FPGA */
   156		writel(0xdeadbeef, base + 1*4);
   157		return 0;
   158	}
   159	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux