Re: [PATCH] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

On Wed, Jul 29, 2020 at 2:26 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Some device nodes in the r8a7745-iwg22d-sodimm.dts are not sorted
> alphabetically. This patch fixes the sorting of nodes and also fixes a
> typo in the stmpe node.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> @@ -53,6 +53,25 @@
>                 clock-frequency = <26000000>;
>         };
>
> +       backlight_lcd: backlight {
> +               compatible = "pwm-backlight";
> +               pwms = <&tpu 3 5000000 PWM_POLARITY_INVERTED>;
> +               brightness-levels = <0 4 8 16 32 64 128 255>;
> +               default-brightness-level = <7>;
> +       };
> +
> +       lcd_panel: lcd {
> +               compatible = "edt,etm043080dh6gp";
> +               power-supply = <&vccq_panel>;
> +               backlight = <&backlight_lcd>;
> +
> +               port {
> +                       lcd_in: endpoint {
> +                               remote-endpoint = <&du_out_rgb0>;
> +                       };
> +               };
> +       };
> +
>         rsnd_sgtl5000: sound {

Shouldn't the sound node be moved below the regulator nodes?

>                 compatible = "simple-audio-card";
>                 simple-audio-card,format = "i2s";
> @@ -68,18 +87,6 @@
>                 };
>         };
>
> -       vccq_sdhi0: regulator-vccq-sdhi0 {
> -               compatible = "regulator-gpio";
> -
> -               regulator-name = "SDHI0 VccQ";
> -               regulator-min-microvolt = <1800000>;
> -               regulator-max-microvolt = <3300000>;
> -
> -               gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;
> -               gpios-states = <1>;
> -               states = <3300000 1>, <1800000 0>;
> -       };
> -
>         vccq_panel: regulator-vccq-panel {
>                 compatible = "regulator-fixed";
>                 regulator-name = "Panel VccQ";

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux