Re: [PATCH v2 4/6] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 DT binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 4, 2020 at 1:57 PM John Stultz <john.stultz@xxxxxxxxxx> wrote:
>
> On Mon, May 11, 2020 at 4:07 AM Ricardo Cañuelo
> <ricardo.canuelo@xxxxxxxxxxxxx> wrote:
> >
> > hi3660-hikey960.dts:
> >   Define a 'ports' node for 'adv7533: adv7533@39' and the
> >   'adi,dsi-lanes' property to make it compliant with the adi,adv7533 DT
> >   binding.
> >
> >   This fills the requirements to meet the binding requirements,
> >   remote endpoints are not defined.
> >
> > hi6220-hikey.dts:
> >   Change property name s/pd-gpio/pd-gpios, gpio properties should be
> >   plural. This is just a cosmetic change.
> >
> > Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@xxxxxxxxxxxxx>
>
> As a heads up.
> So this change sounds sane, but I just bisected it down as the cause
> of a regression on HiKey960 where the adv7511 driver doesn't probe.
>
> I'll dig a bit more on what is going on (the DRM driver is still out
> of tree, so maybe the DTS bits for that are not quite right?), but if
> you have any suggestions, I'll give those a try.

Yes. It ends up the DRM driver dts changes were being done in the
wrong file so it was adding adv7511 bits in the dtsi, which were then
being overridden by your tweak. I'll fixup the pending DRM driver dts
bits. Apologies for the noise.

thanks
-john




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux