On Sun, Jul 26, 2020 at 9:15 PM Clark Wang <xiaoning.wang@xxxxxxx> wrote: > > Add "fsl,spi-only-use-cs1-sel" to fit i.MX8DXL-EVK. > Spi common code does not support use of CS signals discontinuously. > It only uses CS1 without using CS0. So, add this property to re-config > chipselect value. > > Signed-off-by: Clark Wang <xiaoning.wang@xxxxxxx> > --- > Changes: > V2: > - New patch added in the v2 patchset. > --- > Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml > index 143b94a1883a..22882e769e26 100644 > --- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml > @@ -34,6 +34,12 @@ properties: > - const: per > - const: ipg > > + fsl,spi-only-use-cs1-sel: > + description: > + spi common code does not support use of CS signals discontinuously. > + i.MX8DXL-EVK board only uses CS1 without using CS0. Therefore, add > + this property to re-config the chipselect value in the LPSPI driver. This breaks linux-next and you didn't test with 'make dt_binding_check': /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml: properties:fsl,spi-only-use-cs1-sel: {'description': 'spi common code does not support use of CS signals discontinuously. i.MX8DXL-EVK board only uses CS1 without using CS0. Therefore, add this property to re-config the chipselect value in the LPSPI driver.'} is not valid under any of the given schemas (Possible causes of the failure): /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml: properties:fsl,spi-only-use-cs1-sel: 'not' is a required property The problem is you need a type definition for a vendor specific property. In this case 'type: boolean'. Rob