On Sun, Jul 26, 2020 at 01:12:06PM +0200, Konrad Dybcio wrote: > From: Xiaozhe Shi <xiaozhes@xxxxxxxxxxxxxx> > > Add the REVID device driver. The REVID driver will print out the PMIC > revision at probe time. > > Signed-off-by: Xiaozhe Shi <xiaozhes@xxxxxxxxxxxxxx> > [konradybcio@xxxxxxxxx: Fast-forward the driver from kernel 4.14 to 5.8, > convert binding to yaml] > Signed-off-by: Konrad Dybcio <konradybcio@xxxxxxxxx> > --- > .../bindings/soc/qcom/qcom,qpnp-revid.yaml | 38 ++ Bindings should be a separate patch. checkpatch.pl will tell you this. > drivers/soc/qcom/Kconfig | 9 + > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/qpnp-revid.c | 288 ++++++++++++++ > include/linux/qpnp/qpnp-revid.h | 369 ++++++++++++++++++ > 5 files changed, 705 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,qpnp-revid.yaml > create mode 100644 drivers/soc/qcom/qpnp-revid.c > create mode 100644 include/linux/qpnp/qpnp-revid.h