On 7/26/20 9:06 AM, Sam Ravnborg wrote: > Hi Marek. Hi, > On Sat, Jul 25, 2020 at 11:14:56PM +0200, Marek Vasut wrote: >> Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge, this >> one is used in the Raspberry Pi 7" touchscreen display unit. [...] > This looks like a candidate for the simple-bridge-yaml binding. > Did you check if this is sufficient or we really need a new binding? The binding says "Transparent non-programmable DRM bridges", but this TC358762 one is programmable, so I would expect a separate binding file is better in case the driver evolves and needs more DT properties. > If we need a new binding then they to take a look at how simple-bridge > define the ports. You can do this in a simple way than what is used > here. > It looks like this was copied from toshiba,tc358768.yaml, but there are > better examples to follow. I took a subset of the file. [...]
