Quoting harigovi@xxxxxxxxxxxxxx (2020-06-29 06:50:09) > On 2020-06-25 06:37, Stephen Boyd wrote: > > Quoting Harigovindan P (2020-02-17 00:58:42) > >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > >> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > >> index 388f50ad4fde..349db8fe78a5 100644 > >> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > >> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > >> @@ -232,6 +233,57 @@ vreg_bob: bob { [...] > >> + ports { > >> + port@1 { > >> + endpoint { > >> + remote-endpoint = <&panel0_in>; > >> + data-lanes = <0 1 2 3>; > > > > Is this property needed? If it's the default assumption it would be > > nice > > to omit it so that we don't have to think about it. > > This property is needed during panel probe. If this is not mentioned > > here, > mipi_dsi_attach() will fail during panel probe. In dsi_host.c, > dsi_host_attach() > fails since dsi lanes are greater than msm_host lanes. msm_host lanes > are updated > as part of dsi_host_parse_dt. If we dont provide data-lanes in dt, it'll > have default > value and fail in dsi_host_attach(). What is the default value? It looks like dsi_host_parse_dt() says it's using a default but I guess the default is 0 lanes? Why not make it the normal 4 lanes?