Hi Jacopo, On Fri, Jul 17, 2020 at 03:28:46PM +0200, Jacopo Mondi wrote: > Hello, > this series has been broken out from > " [PATCH 0/8] dt-bindings: media: i2c: Convert to json-schema" > which I sent out a few days ago. > > It was a single patch, now it's 13. Not sure it's a good sign :) > > Anyway, in the version sent as part of the mentioned series I just converted > the existing bindings to the json-schema format, without putting to much > attention to what was there. > > As suggested by Laurent I moved to specify properties as dt-schema, to > allow their validation, and that sprinkled to a lot of fun. I found it "fun" too when I started converting bindings to YAML schemas, albeit a quite painful fun at times. It was time consuming for me, as I found out a new mindset was needed to really understand what I was doing. I wonder if it's easier for people with prior exposure to formal languages. > For each patch in the series, the DTS and bindings maintainers are CC-ed. > The whole series has been sent to a limited audience only. > > The series starts with a plain conversion of the existing bindings to > dt-schema. It then fixes a potential issue on a dts user of the sensor, > and then move to remove or demote endpoint properties that were marked as > required in the original text bindings. This of course causes a log of churn > in the existing DTS which use the sensor, and opens some questions there from > which I expect the individual maintainers to provide directions on. > > Finally, the small patch for the driver to initialize DVP default signal > values to what the sensor manual and the bindings report. > > The series ends with the update of the MAINTAINERS file with the new > .yaml binding file and the addition of myself as co-maintainer for the driver. > Steve if you intended to remove yourself please send a patch, I didn't dare to > do it myself :) > > A final note for Rob and his bot: some patches breaks validation of existing > dts, which are then fixed by following patches. Hope this is ok, but it I > have to keep validation of all dts successful, patches would likely be huge > and hinder changes which I preferred to make explicitly in single patches. > > Jacopo Mondi (13): > dt-bindings: media: ov5640: Convert to json-schema > arm64: dts: qcom: apq8016-sbc: Fix CSI-2 lanes routing > dt-bindings: media: ov5640: Do not limit rotation > dt-bindings: media: ti,cal: Remove sensor from example > dt-bindings: media: ov5640: Make bus-type mandatory > dt-bindings: media: ov5640: Require ep properties > dt-bindings: media: ov5640: Remove clock-lanes > dt-bindings: media: ov5640: Remove data-shift > dt-bindings: media: ov5640: Add default for synch signals > dt-bindings: media: ov5640: Demote DVP required properties > media: i2c: ov5640: Initialize DVP polarities as default > MAINTAINERS: ov5640: Add bindings file > dt-bindings: media: ov5640: Add myself as co-maintainer > > .../devicetree/bindings/media/i2c/ov5640.txt | 92 -------- > .../devicetree/bindings/media/i2c/ov5640.yaml | 208 ++++++++++++++++++ > .../devicetree/bindings/media/ti,cal.yaml | 22 -- > MAINTAINERS | 2 + > arch/arm/boot/dts/dra72-evm-common.dtsi | 2 +- > arch/arm/boot/dts/dra76-evm.dts | 2 +- > arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-icore.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +- > arch/arm/boot/dts/stm32mp157c-ev1.dts | 2 +- > .../allwinner/sun50i-a64-amarula-relic.dts | 1 + > .../boot/dts/allwinner/sun50i-a64-pinetab.dts | 1 + > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 8 +- > .../arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +- > drivers/media/i2c/ov5640.c | 16 +- > 16 files changed, 232 insertions(+), 134 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5640.txt > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5640.yaml -- Regards, Laurent Pinchart