RE: [PATCH 1/2] dt-bindings: update usb-c-connector required property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Prashant,

Thanks for the feedback.

> On Fri, Jul 17, 2020 at 08:34:33AM +0100, Biju Das wrote:
> > Some boards have a single SS capable connector. Update usb-c-connector
> > bindings to list port@1 as at least one of the required property.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-
> lad.rj@xxxxxxxxxxxxxx>
> > ---
> >  Ref: https://patchwork.kernel.org/patch/11129567/
> > ---
> >  Documentation/devicetree/bindings/connector/usb-connector.yaml | 7
> > +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > index 9bd52e6..41e0685 100644
> > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > +++ b/Documentation/devicetree/bindings/connector/usb-
> connector.yaml
> > @@ -139,8 +139,11 @@ properties:
> >          description: Sideband Use (SBU), present in USB-C. This describes the
> >            alternate mode connection of which SBU is a part.
> >
> > -    required:
> > -      - port@0
> > +    anyOf:
> > +      - required:
> > +        - port@0
> > +      - required:
> > +        - port@1
>
> So the connector[1] doesn't have any High Speed (D+/D-) lanes? Those are
> supposed to be present on all Type C connectors.

Yes , USB-TypeC connector has  USB3HS0_DP and USB3HS0_DM signals apart from USB3S0_CLK_P, USB3S0_CLK_M,USB3S0_RX_P,USB3S0_RX_M,USB3S0_TX_P,USB3S0_TX_M,
USB3HS0_DP,USB3HS0_DM, USB30_PWEN and USB30_OVC.

But the Connector is a SS Capable connector which supports UFP/DFP and DRP.

Cheers,
Biju

> [1] : https://patchwork.kernel.org/patch/11129567/
>
> Regards,
>
> -Prashant
> >
> >  required:
> >    - compatible
> > --
> > 2.7.4
> >


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux