On Wed, Jul 08, 2020 at 01:43:24PM +0200, Patrick Delaunay wrote:
> Move spi4_pins_a nodes from pinctrl_z to pinctrl
> as the associated pins are not in BANK Z.
>
Yikes, that's a nasty misplacement! Thanks for fixing.
> Fixes: 498a7014989dfdd9a47864b55704dc829ed0dc90
Fixes tag should be of below:
Fixes: 498a7014989d ("ARM: dts: stm32: Add missing pinctrl entries for STM32MP15")
> Signed-off-by: Patrick Delaunay <patrick.delaunay@xxxxxx>
Reviewed-by: Manivannan Sadhasivam <mani@xxxxxxxxxx>
Thanks,
Mani
> ---
>
> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 28 ++++++++++++------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> index 7eb858732d6d..6aedbd7077ff 100644
> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> @@ -1574,6 +1574,20 @@
> };
> };
>
> + spi4_pins_a: spi4-0 {
> + pins {
> + pinmux = <STM32_PINMUX('E', 12, AF5)>, /* SPI4_SCK */
> + <STM32_PINMUX('E', 6, AF5)>; /* SPI4_MOSI */
> + bias-disable;
> + drive-push-pull;
> + slew-rate = <1>;
> + };
> + pins2 {
> + pinmux = <STM32_PINMUX('E', 13, AF5)>; /* SPI4_MISO */
> + bias-disable;
> + };
> + };
> +
> usart2_pins_a: usart2-0 {
> pins1 {
> pinmux = <STM32_PINMUX('F', 5, AF7)>, /* USART2_TX */
> @@ -1776,18 +1790,4 @@
> bias-disable;
> };
> };
> -
> - spi4_pins_a: spi4-0 {
> - pins {
> - pinmux = <STM32_PINMUX('E', 12, AF5)>, /* SPI4_SCK */
> - <STM32_PINMUX('E', 6, AF5)>; /* SPI4_MOSI */
> - bias-disable;
> - drive-push-pull;
> - slew-rate = <1>;
> - };
> - pins2 {
> - pinmux = <STM32_PINMUX('E', 13, AF5)>; /* SPI4_MISO */
> - bias-disable;
> - };
> - };
> };
> --
> 2.17.1
>
