On 6/2/14, 5:35, "Mark Brown" <broonie@xxxxxxxxxx> wrote: >On Tue, Jun 03, 2014 at 03:46:19AM +0800, Chew Chiau Ee wrote: >> From: Darren Hart <dvhart@xxxxxxxxxxxxxxx> >> >> Allow spi-pxa2xx-pci with common clock framework support to build as a >> module by exporting clk_register_clkdev. > >This needs to be patch 1 in the series not patch 2 since the change to >the driver to use the exported symbol depends on this rather than the >other way around. > That was going to be my only comment as well. It's important to ensure things build consistently through the git history. Git bisect is a key use case here, breaking that makes for very cranky kernel engineers :-) Dependencies first, new mechanisms second. -- Darren Hart Open Source Technology Center darren.hart@xxxxxxxxx Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
