On Mon, 2020-07-06 at 20:32 -0700, Randy Dunlap wrote: > On 7/6/20 8:30 PM, Neal Liu wrote: > > Hi Randy, > > > > Thanks for your review. > > > > On Mon, 2020-07-06 at 09:13 -0700, Randy Dunlap wrote: > >> On 7/6/20 2:28 AM, Neal Liu wrote: > >>> diff --git a/drivers/soc/mediatek/devapc/Kconfig b/drivers/soc/mediatek/devapc/Kconfig > >>> new file mode 100644 > >>> index 0000000..b0f7d0e > >>> --- /dev/null > >>> +++ b/drivers/soc/mediatek/devapc/Kconfig > >>> @@ -0,0 +1,17 @@ > >>> +config MTK_DEVAPC > >>> + tristate "Mediatek Device APC Support" > >>> + help > >>> + Device APC is a HW IP controlling internal device security. > >> > >> preferably: s/HW/hardware/ > >> > >>> + MediaTek bus frabric provides TrustZone security support and data > >> > >> fabric > >> > >>> + protection to prevent slaves from being accessed by unexpected > >>> + bus masters. > >>> + Device APC prevents malicious access to internal devices. > >>> + > >>> +config DEVAPC_MT6779 > >>> + tristate "Mediatek MT6779 Device APC driver" > >>> + select MTK_DEVAPC > >>> + help > >>> + Say yes here to enable support Mediatek MT6779 Device APC driver. > >> > >> support for Mediatek > >> > >>> + This driver mainly used to handle the violation with 1 DEVAPC AO/PDs. > >> > >> This driver is mainly used ^^^^^^^^^^^^^^^^ > >> > >> What is that meaningless string of chars? ^^^^^^^ > > > > I did not see any meaningless string of chars from my original patch. > > Is there something wrong? > > To someone who is reading the Kconfig help text but is unfamiliar with this device, > I would say that "1 DEVAPC AO/PDs" is not helpful at all. Got it, I'll try to make it more readable. > > > [1] https://urldefense.com/v3/__https://lkml.org/lkml/2020/7/6/168__;!!CTRNKA9wMg0ARbw!0pAmVqUrtDEDPT-QkQENXso-_umOz2nbe-DDIlMb1sEsD57BaKtDZF47QFTfMSP-$ > > > >> > >>> + The violation information are logged for further analysis or > >> > >> is > >> > >>> + countermeasures. > >> > >> thanks. > > > > > thanks.
