On Mon, 2020-06-29 at 15:53 -0600, Rob Herring wrote: > On Thu, 18 Jun 2020 19:33:32 +0800, Hanks Chen wrote: > > From: Andy Teng <andy.teng@xxxxxxxxxxxx> > > > > Add devicetree bindings for MediaTek MT6779 pinctrl driver. > > > > Signed-off-by: Andy Teng <andy.teng@xxxxxxxxxxxx> > > --- > > .../bindings/pinctrl/mediatek,mt6779-pinctrl.yaml | 210 ++++++++++++++++++++ > > 1 file changed, 210 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.example.dts:21:18: fatal error: dt-bindings/pinctrl/mt6779-pinfunc.h: No such file or directory > #include <dt-bindings/pinctrl/mt6779-pinfunc.h> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > scripts/Makefile.lib:315: recipe for target 'Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.example.dt.yaml' failed > make[1]: *** [Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > Makefile:1347: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > > See https://patchwork.ozlabs.org/patch/1312018 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. > I already ran the dt_binding_check and it looks good. > > > Here, you need patch 2 to come first or merge it into this patch as it > is part of the binding. > I'll merge it into this patch in next version. Thank you for your comment. Hanks > Rob >
