Re: [linux-sunxi] Re: [PATCH v2 2/5] drm: panel: Add Starry KR070PE2T

[Pascal Roeleven <dev@xxxxxxxxxxxxxxxxx>]

Hi Laurent,

Good catch. It's actually the connector type which is wrong. The 
connector_type should be DRM_MODE_CONNECTOR_DPI. If you would include 
this in your patch series, you can have my acked-by.

Regards,
Pascal

On 2020-06-28 09:28, Laurent Pinchart wrote:
> Hi Pascal,
>
> On Fri, Mar 20, 2020 at 12:21:33PM +0100, Pascal Roeleven wrote:
> > The KR070PE2T is a 7" panel with a resolution of 800x480.
> >
> > KR070PE2T is the marking present on the ribbon cable. As this panel is
> > probably available under different brands, this marking will catch
> > most devices.
> >
> > As I can't find a datasheet for this panel, the bus_flags are instead
> > from trial-and-error. The flags seem to be common for these kind of
> > panels as well.
> >
> > Signed-off-by: Pascal Roeleven <dev@xxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 29 
> > ++++++++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c 
> > b/drivers/gpu/drm/panel/panel-simple.c
> > index e14c14ac6..b3d257257 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -2842,6 +2842,32 @@ static const struct panel_desc 
> > shelly_sca07010_bfn_lnn = {
> >  	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> >  };
> >
> > +static const struct drm_display_mode starry_kr070pe2t_mode = {
> > +	.clock = 33000,
> > +	.hdisplay = 800,
> > +	.hsync_start = 800 + 209,
> > +	.hsync_end = 800 + 209 + 1,
> > +	.htotal = 800 + 209 + 1 + 45,
> > +	.vdisplay = 480,
> > +	.vsync_start = 480 + 22,
> > +	.vsync_end = 480 + 22 + 1,
> > +	.vtotal = 480 + 22 + 1 + 22,
> > +	.vrefresh = 60,
> > +};
> > +
> > +static const struct panel_desc starry_kr070pe2t = {
> > +	.modes = &starry_kr070pe2t_mode,
> > +	.num_modes = 1,
> > +	.bpc = 8,
> > +	.size = {
> > +		.width = 152,
> > +		.height = 86,
> > +	},
> > +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | 
> > DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
> > +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>
> I'm trying to fix inconsistencies in the panel-simple driver, and this
> caught my eyes. MEDIA_BUS_FMT_RGB888_1X24 isn't a correct format for
> LVDS panels. MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> MEDIA_BUS_FMT_RGB888_1X7X4_SPWG or MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA
> should be used instead. As I couldn't find documentation for the panel,
> I can't tell which format is correct. Could you please help ?
>
> > +};
> > +
> >  static const struct drm_display_mode starry_kr122ea0sra_mode = {
> >  	.clock = 147000,
> >  	.hdisplay = 1920,
> > @@ -3474,6 +3500,9 @@ static const struct of_device_id 
> > platform_of_match[] = {
> >  	}, {
> >  		.compatible = "shelly,sca07010-bfn-lnn",
> >  		.data = &shelly_sca07010_bfn_lnn,
> > +	}, {
> > +		.compatible = "starry,kr070pe2t",
> > +		.data = &starry_kr070pe2t,
> >  	}, {
> >  		.compatible = "starry,kr122ea0sra",
> >  		.data = &starry_kr122ea0sra,
>
> --
> Regards,
>
> Laurent Pinchart