On 6/22/20 2:37 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > The phy-supply property is often added to MAC nodes but this is wrong > conceptually. These supplies should be part of the PHY node on the > MDIO bus. Add phy-supply property at PHY level to mdio.yaml. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/net/mdio.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/mdio.yaml b/Documentation/devicetree/bindings/net/mdio.yaml > index d6a3bf8550eb..9c10012c2093 100644 > --- a/Documentation/devicetree/bindings/net/mdio.yaml > +++ b/Documentation/devicetree/bindings/net/mdio.yaml > @@ -90,6 +90,10 @@ patternProperties: > Delay after the reset was deasserted in microseconds. If > this property is missing the delay will be skipped. > > + phy-supply: > + description: > + Phandle to the regulator that provides the supply voltage to the PHY. I do not see how you can come up with a generic name here, there could be PHYs supporting different voltages (3.3V, 1.8V, 1.5V) depending on their operation mode/strapping, there can also be different parts of the PHY being powered by different regulators, the analog part could be on an always-on island such that Wake-on-LAN from the PHY could be done, and the digital part could be on a complete different island. -- Florian