Hi Rob, On 17/06/20 19:11, Rob Herring wrote: > On Wed, 17 Jun 2020 15:11:43 +0200, Luca Ceresoli wrote: >> The definition of "xxx-in-supply" was generic, thus define in detail the >> possible cases for each chip variant. >> >> Also document that the only possible I2C slave address is 0x60 as per the >> datasheet and fix the second example accordingly. >> >> Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx> >> >> --- >> >> Changes in v2: >> - this patch replaces patch "regulator: lp87565: dt: remove duplicated >> section" in RFC,v1 (Rob Herring) >> - use capital letters consistently (Lee Jones) >> - replace "regulator" -> "mfd" in subject line (Lee Jones) >> - replace "dt:" suffix with "dt-bindings:" prefix in subject line >> --- >> .../devicetree/bindings/mfd/lp87565.txt | 79 ----------- >> .../devicetree/bindings/mfd/ti,lp875xx.yaml | 134 ++++++++++++++++++ >> 2 files changed, 134 insertions(+), 79 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/mfd/lp87565.txt >> create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp875xx.yaml >> > > > My bot found errors running 'make dt_binding_check' on your patch: > > Error: Documentation/devicetree/bindings/mfd/ti,lp875xx.example.dts:20.9-14 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:315: recipe for target 'Documentation/devicetree/bindings/mfd/ti,lp875xx.example.dt.yaml' failed > make[1]: *** [Documentation/devicetree/bindings/mfd/ti,lp875xx.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > Makefile:1347: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 Apologies, v3 incoming with these fixed (and dt_binding_check run in its entirety this time). Thanks, -- Luca