On Thu, Jun 18, 2020 at 06:01:29PM +0200, Heiko Stübner wrote: > Am Donnerstag, 18. Juni 2020, 17:47:48 CEST schrieb Russell King - ARM Linux admin: > > On Thu, Jun 18, 2020 at 05:41:54PM +0200, Heiko Stübner wrote: > > > Though I'm not sure how this fits in the whole bringup of ethernet phys. > > > Like the phy is dependent on the underlying ethernet controller to > > > actually turn it on. > > > > > > I guess we should check the phy-state and if it's not accessible, just > > > keep the values and if it's in a suitable state do the configuration. > > > > > > Calling a vsc8531_config_clkout() from both the vsc8531_config_init() > > > as well as the clk_(un-)prepare and clk_set_rate functions and being > > > protected by a check against phy_is_started() ? > > > > It sounds like it doesn't actually fit the clk API paradym then. I > > see that Rob suggested it, and from the DT point of view, it makes > > complete sense, but then if the hardware can't actually be used in > > the way the clk API expects it to be used, then there's a semantic > > problem. > > > > What is this clock used for? > > It provides a source for the mac-clk for the actual transfers, here to > provide the 125MHz clock needed for the RGMII interface . > > So right now the old rk3368-lion devicetree just declares a stub > fixed-clock and instructs the soc's clock controller to use it [0] . > And in the cover-letter here, I show the update variant with using > the clock defined here. > > > I've added the idea from my previous mail like shown below [1]. > which would take into account the phy-state. > > But I guess I'll wait for more input before spamming people with v6. Let's get a handle on exactly what this is. The RGMII bus has two clocks: RXC and TXC, which are clocked at one of 125MHz, 25MHz or 2.5MHz depending on the RGMII data rate. Some PHYs replace TXC with GTX clock, which always runs at 125MHz. These clocks are not what you're referring to. You are referring to another commonly provided clock between the MAC and the PHY, something which is not unique to your PHY. We seem to be heading down a path where different PHYs end up doing different things in DT for what is basically the same hardware setup, which really isn't good. :( We have at803x using: qca,clk-out-frequency qca,clk-out-strength qca,keep-pll-enabled which are used to control the CLK_25M output pin on the device, which may be used to provide a reference clock for the MAC side, selecting between 25M, 50M, 62.5M and 125MHz. This was introduced in November 2019, so not that long ago. Broadcom PHYs configure their 125MHz clock through the PHY device flags passed from the MAC at attach/connect time. There's the dp83867 and dp83869 configuration (I'm not sure I can make sense of it from reading the code) using ti,clk-output-sel - but it looks like it's the same kind of thing. Introduced February 2018 into one driver, and November 2019 in the other. It seems the Micrel PHYs produce a 125MHz clock irrespective of any configuration (maybe configured by firmware, or hardware strapping?) So it seems we have four ways of doing the same thing today, and now the suggestion is to implement a fifth different way. I think there needs to be some consolidation here, maybe choosing one approach and sticking with it. Hence, I disagree with Rob - we don't need a fifth approach, we need to choose one approach and decide that's our policy for this and apply it evenly across the board, rather than making up something different each time a new PHY comes along. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
