On 12/06/2020 07:55:53-0400, Kevin P. Fleming wrote: > On Wed, Jun 10, 2020 at 11:22 AM Alexandre Belloni > <alexandre.belloni@xxxxxxxxxxx> wrote: > > I'd like to avoid having more error messages in the driver (and whole > > subsystem). Can you move the ABX8XX_REG_CFG_KEY setting earlier in > > abx80x_probe so you don't have to do it here and avoid duplication the > > error message? > > > > Based on my reading of the app manual this won't work properly, as > setting the configuration key only allows writing to one register, and > then the key is reset. It has to be set to allow enabling the trickle > charger, and also to allow enabling the autocalibration filter > capacitor. > That is correct and I forgot about that. Can you move just setting the key to a function as a preliminary patch? > > The RTC can still work if this fails and the rror is transient, maybe > > just warn and continue. It will be set on the next probe. > > Will fix in the next version of the patch. > > Thanks for the review! -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
