On Wed, Jun 10, 2020 at 11:22 AM Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> wrote: > I'd like to avoid having more error messages in the driver (and whole > subsystem). Can you move the ABX8XX_REG_CFG_KEY setting earlier in > abx80x_probe so you don't have to do it here and avoid duplication the > error message? > Based on my reading of the app manual this won't work properly, as setting the configuration key only allows writing to one register, and then the key is reset. It has to be set to allow enabling the trickle charger, and also to allow enabling the autocalibration filter capacitor. > The RTC can still work if this fails and the rror is transient, maybe > just warn and continue. It will be set on the next probe. Will fix in the next version of the patch. Thanks for the review!
