On Tue, Jun 9, 2020 at 6:14 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > --- > > .../bindings/rtc/abracon,abx80x.txt | 6 ++++ > > drivers/rtc/rtc-abx80x.c | 34 +++++++++++++++++++ > > 2 files changed, 40 insertions(+) > > Binding should be a separate patch? Indeed, it was re-sent with the patches separated. > > +All of the devices can have a 47pf capacitor attached to increase the > > +autocalibration accuracy of their RC oscillators. To enable usage of the > > +capacitor the following property has to be defined: > > + > > + - "abracon,autocal-filter" > > Can't the standard 'quartz-load-femtofarads' property be used here? You > might not need to know the value, but presence of the property can > enable the feature. On these devices the capacitor is connected to the RC oscillator, not the crystal oscillator, so this property is controlling a different function. I'm certainly open to suggestions for different names for the property if that is desired.
