On Sat, May 30, 2020 at 08:32:22AM -0400, Kevin P. Fleming wrote: > All of the parts supported by this driver can make use of a > small capacitor to improve the accuracy of the autocalibration > process for their RC oscillators. If a capacitor is connected, > a configuration register must be set to enable its use, so a > new Device Tree property has been added for that purpose. > > Signed-off-by: Kevin P. Fleming <kevin+linux@xxxxxxx> > Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx> > Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > To: linux-rtc@xxxxxxxxxxxxxxx > To: devicetree@xxxxxxxxxxxxxxx > --- > .../bindings/rtc/abracon,abx80x.txt | 6 ++++ > drivers/rtc/rtc-abx80x.c | 34 +++++++++++++++++++ > 2 files changed, 40 insertions(+) Binding should be a separate patch? > > diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt > index 2405e35a1bc0..ad5d59ed6f24 100644 > --- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt > +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt > @@ -29,3 +29,9 @@ and valid to enable charging: > - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V) > - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output > resistor, the other values are in kOhm. > + > +All of the devices can have a 47pf capacitor attached to increase the > +autocalibration accuracy of their RC oscillators. To enable usage of the > +capacitor the following property has to be defined: > + > + - "abracon,autocal-filter" Can't the standard 'quartz-load-femtofarads' property be used here? You might not need to know the value, but presence of the property can enable the feature. Rob
