Hi Lee, On 04/06/20 08:01, Lee Jones wrote: > On Wed, 03 Jun 2020, Luca Ceresoli wrote: > >> Add the LP87524-Q1 to the lp87565 bindings document along with an example. > > Keep the way to describe model numbers consistent. > > I suggest LP87565 here (even though the filename is in lower case). Ok. >> Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/mfd/lp87565.txt | 47 ++++++++++++++++++- > > This is an MFD patch. > > Please change the patch subject to reflect that. Done that here and in patch 2 as well, and also changed from "dt:" to a "dt-bindings:" prefix. This will be in v2: dt-bindings: mfd: lp87565: add LP87524-Q1 variant >> 1 file changed, 46 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt >> index b75ae23a1ef3..839eac6b75c2 100644 >> --- a/Documentation/devicetree/bindings/mfd/lp87565.txt >> +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt >> @@ -1,7 +1,8 @@ >> TI LP87565 PMIC MFD driver >> >> Required properties: >> - - compatible: one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1" >> + - compatible: one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1", >> + "ti,lp87524-q1" > > Maybe have 2 per line. It would really help with my OCD! Ok. -- Luca
