Hi Matthew, On 6/2/2020 9:11 AM, Matthew Hagan wrote: > This patch set adds support for the Meraki MX64(W) and MX65(W) security > devices. There are four devices in total, all using the same basic hardware. > > The MX64 series has five ethernet ports connected to the BCM SRAB. The MX65 > series has two ports conected to the SRAB, and two QCA8337 switches connected > by SGMII to SRAB ports 4 and 5, each providing five additional ports. > > The W variants of these devices have two BCM43520s on the PCIe bus. On the > non-wireless variants PCIe is inactive, hence separate dts files. > > 1/3 contains common bindings for both Meraki devices. > 2/3 contains MX64 specific bindings. > 3/3 contains MX65 specific bindings. Glad to see those patches being submitted upstream to support those devices, don't we need a change to arch/arm/boot/dts/Makefile to add those DTS files to be built when ARCH_BCM_NSP is enabled? > > Note that Chris Packham's "[PATCH 2/2] ARM: dts: NSP: avoid unnecessary probe > deferrals" is also necessary. Humm, I am not sure this patch is really the way to go, but I have to look at it again. > > Thanks, > Matthew > > Matthew Hagan (3): > ARM: dts: NSP: Add common bindings for Meraki MX64/65 > ARM: dts: NSP: Add support for Cisco Meraki MX64(W) > ARM: dts: NSP: Add support for Cisco Meraki MX65(W) > > arch/arm/boot/dts/bcm958625-mx64.dts | 15 + > arch/arm/boot/dts/bcm958625-mx64w.dts | 23 ++ > arch/arm/boot/dts/bcm958625-mx64x.dtsi | 136 ++++++++ > arch/arm/boot/dts/bcm958625-mx65.dts | 15 + > arch/arm/boot/dts/bcm958625-mx65w.dts | 23 ++ > arch/arm/boot/dts/bcm958625-mx65x.dtsi | 321 +++++++++++++++++++ > arch/arm/boot/dts/bcm958625-mx6x-common.dtsi | 172 ++++++++++ > 7 files changed, 705 insertions(+) > create mode 100644 arch/arm/boot/dts/bcm958625-mx64.dts > create mode 100644 arch/arm/boot/dts/bcm958625-mx64w.dts > create mode 100644 arch/arm/boot/dts/bcm958625-mx64x.dtsi > create mode 100644 arch/arm/boot/dts/bcm958625-mx65.dts > create mode 100644 arch/arm/boot/dts/bcm958625-mx65w.dts > create mode 100644 arch/arm/boot/dts/bcm958625-mx65x.dtsi > create mode 100644 arch/arm/boot/dts/bcm958625-mx6x-common.dtsi > -- Florian
