Hi! > ping? Well, I thought that we maybe do not need standard LEDs on medical hardware. > On Fri, Apr 24, 2020 at 02:44:23PM +0200, Sebastian Reichel wrote: > > Hi, > > > > On Fri, Apr 24, 2020 at 11:32:26AM +0200, Pavel Machek wrote: > > > On Thu 2020-04-16 16:51:23, Sebastian Reichel wrote: > > > > From: Ian Ray <ian.ray@xxxxxx> > > > > > > > > Use kernel LED interface for the alarm LEDs. > > > > > > Could we get these changes cced to LED maintainers? > > > > Sorry, you are not turning up via get_maintainer.pl and usually > > subsystem maintainers are not CC'd for every DT device instance. > > E.g. I do not want to be always CC'd for DT board file containing > > a battery/charger. I'm quite surprised you want to be CC'd for > > them, just looking at ARM DT files there are over 1000 instances > > of leds. Well, we have mess in the naming; I'd like to clear it up. > > > > + alarm1 { > > > > + label = "alarm:red"; > > > > + gpios = <&gpio7 3 GPIO_ACTIVE_HIGH>; > > > > + }; > > > > > > So... What is function of these leds, and can we get naming more > > > consistent with rest of the kernel? > > > > The device is a medical patient monitor and these are alarm LEDs > > informing about critical device or patient status. They are > > referenced by their color (those are discrete LEDs, not a > > multi-color one) basically everywhere. The only exception is > > "silenced", which means that audible alarm is surpressed. I > > don't think we have something comparable for any of those LEDs > > in the mainline tree. Actually, we have "platform:*:mute" LEDs, that could be used for "silenced". Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: PGP signature