On Tue, 26 May 2020 21:56:28 +0200
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> This property does not describe very well its purpose: it describes
> the ECC engine type, also called provider. Deprecate it in favor of
> nand-ecc-provider. In the mean time, update a bit the description of
> the property to make it more accurate.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/mtd/nand-controller.yaml | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> index a35ff8227427..256080ba50bd 100644
> --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> @@ -46,16 +46,17 @@ patternProperties:
> description:
> Contains the native Ready/Busy IDs.
>
> - nand-ecc-mode:
> + nand-ecc-provider:
> allOf:
> - $ref: /schemas/types.yaml#/definitions/string
> - enum: [ none, soft, hw, on-die ]
^"on-controller" ?
> description:
> - Desired ECC engine, either hardware (most of the time
> - embedded in the NAND controller) or software correction
> - (Linux will handle the calculations). soft_bch is deprecated
> - and should be replaced by soft and nand-ecc-algo.
> - hw_syndrome is deprecated and should be
> + Desired ECC engine provider, either hardware (most of the time
^Preferred ECC engine type, ...
> + embedded in the NAND controller, but can also be external) or
> + software correction (the OS will handle the calculations).
> + The nand-ecc-mode property is deprecated in favor of this one.
> + soft_bch is deprecated and should be replaced by soft and
> + nand-ecc-algo. hw_syndrome is deprecated and should be
> replaced by hw and nand-ecc-placement.
Which you do here, so patch 15 is not needed.
>
> nand-ecc-placement:
> @@ -148,7 +149,7 @@ examples:
>
> nand@0 {
> reg = <0>;
> - nand-ecc-mode = "soft";
> + nand-ecc-provider = "soft";
> nand-ecc-algo = "bch";
>
> /* controller specific properties */
