On Fri, May 22, 2020 at 5:25 PM Jishnu Prakash <jprakash@xxxxxxxxxxxxxx> wrote: > > This commit includes the following changes: > > Add a common function used for read_raw callback for both PMIC5 > and PMIC7 ADCs. > > Add exit function for ADC. > > Add info_property under adc_data to more efficiently distinguish > PMIC5 and PMIC7 ADCs. ... > - if (of_device_is_compatible(node, "qcom,spmi-adc7")) > - indio_dev->info = &adc7_info; > - else > - indio_dev->info = &adc5_info; > + platform_set_drvdata(pdev, adc); Ping-pong style of series. Can we convert to .info before we introduce above check for compatibility? -- With Best Regards, Andy Shevchenko
