Hello Andy, On Fri, May 22, 2020 at 12:18:24PM +0300, Andy Shevchenko wrote: > On Fri, May 22, 2020 at 10:56:13AM +0200, Uwe Kleine-König wrote: > > On Fri, May 22, 2020 at 03:41:59PM +0800, Rahul Tanwar wrote: > > > > + io_base = devm_platform_ioremap_resource(pdev, 0); > > > + if (IS_ERR(io_base)) > > > > error message here? > > platform core provides it. No need to duplicate (esp. taking into consideration > that it can issue IIRC three different error messages depending on actual error). Ah, missed that. Indeed that's fine as is in the patch. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
