Re: [PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Florian

On 5/20/20 12:45 PM, Florian Fainelli wrote:

On 5/20/2020 10:20 AM, Dan Murphy wrote:
Andrew/Florian

On 5/20/20 11:43 AM, Andrew Lunn wrote:
I am interested in knowing where that is documented.  I want to RTM I
grepped for a few different words but came up empty
Hi Dan

It probably is not well documented, but one example would be

Documentation/devicetree/bindings/net/ethernet-controller.yaml

says:

        # RX and TX delays are added by the MAC when required
        - rgmii

        # RGMII with internal RX and TX delays provided by the PHY,
        # the MAC should not add the RX or TX delays in this case
        - rgmii-id

        # RGMII with internal RX delay provided by the PHY, the MAC
        # should not add an RX delay in this case
        - rgmii-rxid

        # RGMII with internal TX delay provided by the PHY, the MAC
        # should not add an TX delay in this case

        Andrew
OKI I read that.  I also looked at a couple other drivers too.

I am wondering if rx-internal-delay and tx-internal-delay should become
a common property like tx/rx fifo-depth
And properly document how to use it or at least the expectation on use.
Yes they should, and they should have an unit associated with the name.


UGH I think I just got volunteered to do make them common.

Dan




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux