On Wed, May 20, 2020 at 07:18:34AM -0500, Dan Murphy wrote: > Add the internal delay values into the header and update the binding > with the internal delay properties. > > Signed-off-by: Dan Murphy <dmurphy@xxxxxx> > --- > .../devicetree/bindings/net/ti,dp83869.yaml | 16 ++++++++++++++++ > include/dt-bindings/net/ti-dp83869.h | 18 ++++++++++++++++++ > 2 files changed, 34 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ti,dp83869.yaml b/Documentation/devicetree/bindings/net/ti,dp83869.yaml > index 5b69ef03bbf7..344015ab9081 100644 > --- a/Documentation/devicetree/bindings/net/ti,dp83869.yaml > +++ b/Documentation/devicetree/bindings/net/ti,dp83869.yaml > @@ -64,6 +64,20 @@ properties: > Operational mode for the PHY. If this is not set then the operational > mode is set by the straps. see dt-bindings/net/ti-dp83869.h for values > > + ti,rx-internal-delay: > + $ref: /schemas/types.yaml#definitions/uint32 > + description: | > + RGMII Receive Clock Delay - see dt-bindings/net/ti-dp83869.h > + for applicable values. Required only if interface type is > + PHY_INTERFACE_MODE_RGMII_ID or PHY_INTERFACE_MODE_RGMII_RXID. Hi Dan Having it required with PHY_INTERFACE_MODE_RGMII_ID or PHY_INTERFACE_MODE_RGMII_RXID is pretty unusual. Normally these properties are used to fine tune the delay, if the default of 2ns does not work. Andrew