Thanks Andy, Question below: On Wed, May 20, 2020 at 1:24 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Wed, May 20, 2020 at 12:51:12PM +0300, Tali Perry wrote: > > Add Nuvoton NPCM BMC I2C controller driver. > > ... > > > +#ifdef CONFIG_DEBUG_FS > > Why?! It is made to save code size if CONFIG_DEBUG_FS is not defined? We see a lot of kernel code that is doing it. So could you elaborate what is the problem? > > > +#include <linux/debugfs.h> > > +#endif >