> -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Monday, May 18, 2020 10:22 PM > To: G Jaya Kumaran, Vineetha <vineetha.g.jaya.kumaran@xxxxxxxxx> > Cc: thierry.reding@xxxxxxxxx; u.kleine-koenig@xxxxxxxxxxxxxx; linux- > pwm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Wan Mohamad, Wan > Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@xxxxxxxxx>; Shevchenko, > Andriy <andriy.shevchenko@xxxxxxxxx> > Subject: Re: [PATCH 3/3] dt-bindings: pwm: keembay: Add bindings for Intel > Keem Bay PWM > > On Sun, May 17, 2020 at 09:52:40PM +0800, > vineetha.g.jaya.kumaran@xxxxxxxxx wrote: > > From: "Vineetha G. Jaya Kumaran" <vineetha.g.jaya.kumaran@xxxxxxxxx> > > > > Add PWM Device Tree bindings documentation for the Intel Keem Bay SoC. > > > > Signed-off-by: Vineetha G. Jaya Kumaran > > <vineetha.g.jaya.kumaran@xxxxxxxxx> > > --- > > .../devicetree/bindings/pwm/pwm-keembay.yaml | 39 > ++++++++++++++++++++++ > > 1 file changed, 39 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > > Use compatible string for filename: intel,keembay-pwn.yaml > Will fix the filename in v2. > > > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > > b/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > > new file mode 100644 > > index 0000000..00968d7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > > @@ -0,0 +1,39 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > Dual license new bindings: > > (GPL-2.0-only OR BSD-2-Clause) > OK, will update the licensing info. > > +# Copyright (C) 2020 Intel Corporation %YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pwm/pwm-keembay.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Intel Keem Bay PWM Device Tree Bindings > > + > > +maintainers: > > + - Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@xxxxxxxxx> > > + > > +allOf: > > + - $ref: pwm.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - intel,keembay-pwm > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + description: > > + phandle to the reference clock. > > How many clocks? (maxItems: 1?) > > You can drop the description. > 1 clock is needed for this case, will add in maxItems and drop the description. > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + > > +examples: > > + - | > > + pwm@203200a0 { > > + compatible = "intel,keembay-pwm"; > > + reg = <0x0 0x203200a0 0x0 0xe8>; > > + clocks = <&scmi_clk KEEM_BAY_A53_GPIO>; > > + }; > > -- > > 1.9.1 > >
