Andrew
On 5/19/20 1:29 PM, Andrew Lunn wrote:
On Tue, May 19, 2020 at 09:58:18AM -0700, Jakub Kicinski wrote:
On Tue, 19 May 2020 09:18:11 -0500 Dan Murphy wrote:
If the op-mode for the device is not set in the device tree then set
the strapped op-mode and store it for later configuration.
Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
../drivers/net/phy/dp83869.c: In function0 dp83869_set_strapped_mode:
../drivers/net/phy/dp83869.c:171:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
171 | if (val < 0)
| ^
Hi Jakub
This happens a lot with PHY drivers. The register being read is a u16,
so that is what people use.
Yes this is what happened but phy_read_mmd returns an int so the
declaration of val should be an int.
I will update that in v2
Is this now a standard GCC warning? Or have you turned on extra
checking?
I still was not able to reproduce this warning with gcc-9.2. I would
like to know the same
Dan
