On Thu, May 22, 2014 at 02:58:57PM +0200, Geert Uytterhoeven wrote: > On Thu, May 22, 2014 at 2:50 PM, Laurent Pinchart > <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > On Thursday 22 May 2014 14:33:17 Geert Uytterhoeven wrote: > >> <dt-bindings/interrupt-controller/irq.h> is already included by > >> r8a7779.dtsi. > > > > Isn't it better, like with C code, to explicitly include headers that provide > > the macros you need, instead of relying on implicit #include's that could > > change later ? OK, in this specific case, it's very unlikely that r8a7779.dtsi > > would stop including <dt-bindings/interrupt-controller/irq.h>, but in the > > general case I believe explicit includes to be good practice. > > You're right. I was a bit overzealous. > > Simon, please drop this. Done. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
