On Mon, May 18, 2020 at 8:51 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Fri, May 08, 2020 at 11:29:32AM +0300, Roger Quadros wrote: > > Add DT binding schema for J721e system controller. > > > > Signed-off-by: Roger Quadros <rogerq@xxxxxx> > > --- > > .../bindings/mfd/ti,j721e-syscon.yaml | 69 +++++++++++++++++++ > > 1 file changed, 69 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/ti,j721e-syscon.yaml > > Use the compatible string for filename. > > > > > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-syscon.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-syscon.yaml > > new file mode 100644 > > index 000000000000..e832fb43f884 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-syscon.yaml > > @@ -0,0 +1,69 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (C) 2020 Texas Instruments Incorporated - http://www.ti.com/ > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mfd/ti,j721e-syscon.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: TI J721e System Controller Registers R/W Device Tree Bindings > > + > > +description: | > > + This represents the Control Module registers (CTRL_MMR0) on the SoC. > > + System controller node represents a register region containing a set > > + of miscellaneous registers. The registers are not cohesive enough to > > + represent as any specific type of device. The typical use-case is > > + for some other node's driver, or platform-specific code, to acquire > > + a reference to the syscon node (e.g. by phandle, node path, or > > + search using a specific compatible value), interrogate the node (or > > + associated OS driver) to determine the location of the registers, > > + and access the registers directly. > > + > > +maintainers: > > + - Kishon Vijay Abraham I <kishon@xxxxxx> > > + - Roger Quadros <rogerq@xxxxxx > > + > > +allOf: > > + - $ref: "syscon.yaml#" > > Drop this as it is not needed. > > > + > > +properties: > > + compatible: > > + anyOf: > > + - items: > > + - enum: > > + - ti,j721e-system-controller > > + > > + - const: syscon > > What about simple-mfd? > > > + > > + - contains: > > + const: syscon > > + additionalItems: true > > Should be dropped. > > You are going to need a 'select' entry or this will match on any syscon > or simple-mfd node: > > select: > properties: > compatible: > contains: > const: ti,j721e-system-controller > required: > - compatible Sorry, forget the 'select' part (still should drop the 2nd clause). I'd found a bug in what handles this automatically, but it's only when you have 'simple-mfd' and not 'syscon'. Rob
