On Fri, May 15, 2020 at 01:47:54PM +0300, Serge Semin wrote: > Seeing all of the DW SPI driver components like DW SPI DMA/PCI/MMIO > depend on the DW SPI core code it's better to use the if-endif > conditional kernel config statement to signify that common dependency. Makes sense! Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Co-developed-by: Georgy Vlasov <Georgy.Vlasov@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Georgy Vlasov <Georgy.Vlasov@xxxxxxxxxxxxxxxxxxxx> > Co-developed-by: Ramil Zaripov <Ramil.Zaripov@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Ramil Zaripov <Ramil.Zaripov@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > Cc: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx> > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > Cc: Paul Burton <paulburton@xxxxxxxxxx> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > Cc: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Allison Randal <allison@xxxxxxxxxxx> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Cc: Gareth Williams <gareth.williams.jx@xxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx > --- > drivers/spi/Kconfig | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index 6a84f3dad35c..3cdf8310d185 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -226,17 +226,20 @@ config SPI_DESIGNWARE > help > general driver for SPI controller core from DesignWare > > +if SPI_DESIGNWARE > + > config SPI_DW_DMA > bool "DMA support for DW SPI controller" > - depends on SPI_DESIGNWARE > > config SPI_DW_PCI > tristate "PCI interface driver for DW SPI core" > - depends on SPI_DESIGNWARE && PCI > + depends on PCI > > config SPI_DW_MMIO > tristate "Memory-mapped io interface driver for DW SPI core" > - depends on SPI_DESIGNWARE > + depends on HAS_IOMEM > + > +endif > > config SPI_DLN2 > tristate "Diolan DLN-2 USB SPI adapter" > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko
