On Fri, May 15, 2020 at 01:47:53PM +0300, Serge Semin wrote: > Since there is a generic method available to initialize the DW SPI DMA > interface on any DT and ACPI-based platforms, which in general can be > designed with not only DW DMAC but with any DMA engine on board, we can > freely remove the CONFIG_DW_DMAC_PCI config from dependency list of > CONFIG_SPI_DW_DMA. Especially seeing that we don't use anything DW DMAC > specific in the new driver. Right, and used data structures are always available at compile time. Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Co-developed-by: Georgy Vlasov <Georgy.Vlasov@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Georgy Vlasov <Georgy.Vlasov@xxxxxxxxxxxxxxxxxxxx> > Co-developed-by: Ramil Zaripov <Ramil.Zaripov@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Ramil Zaripov <Ramil.Zaripov@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > Cc: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx> > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > Cc: Paul Burton <paulburton@xxxxxxxxxx> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Allison Randal <allison@xxxxxxxxxxx> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Cc: Gareth Williams <gareth.williams.jx@xxxxxxxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx > --- > drivers/spi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index 03b061975f70..6a84f3dad35c 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -228,7 +228,7 @@ config SPI_DESIGNWARE > > config SPI_DW_DMA > bool "DMA support for DW SPI controller" > - depends on SPI_DESIGNWARE && DW_DMAC_PCI > + depends on SPI_DESIGNWARE > > config SPI_DW_PCI > tristate "PCI interface driver for DW SPI core" > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko