On Fri 08 May 13:41 PDT 2020, Sumit Semwal wrote:
> From: Nisha Kumari <nishakumari@xxxxxxxxxxxxxx>
>
> Adding the devicetree binding for labibb regulator.
>
> Signed-off-by: Nisha Kumari <nishakumari@xxxxxxxxxxxxxx>
> Signed-off-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
Sorry, I missed this when we talked about it. But please rewrite this in
yaml.
>
> --
> v2: updated for better compatible string and names.
> ---
> .../regulator/qcom-labibb-regulator.txt | 47 +++++++++++++++++++
> 1 file changed, 47 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.txt
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.txt
> new file mode 100644
> index 000000000000..6e639d69f780
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.txt
> @@ -0,0 +1,47 @@
> +Qualcomm's LAB(LCD AMOLED Boost)/IBB(Inverting Buck Boost) Regulator
> +
> +LAB can be used as a positive boost power supply and IBB can be used as a negative
> +boost power supply for display panels. Currently implemented for pmi8998.
> +
> +Main node required properties:
> +
> +- compatible: Must be:
> + "qcom,pmi8998-lab-ibb"
> +- #address-cells: Must be 1
> +- #size-cells: Must be 0
But the children doesn't have reg properties...
> +
> +LAB subnode required properties:
> +
> +- interrupts: Specify the interrupts as per the interrupt
> + encoding.
> +- interrupt-names: Interrupt names to match up 1-to-1 with
> + the interrupts specified in 'interrupts'
> + property.
Do specify the expected string (and given that you already have the
lab & ibb subnodes, you don't need to include this in the string).
Regards,
Bjorn
> +
> +IBB subnode required properties:
> +
> +- interrupts: Specify the interrupts as per the interrupt
> + encoding.
> +- interrupt-names: Interrupt names to match up 1-to-1 with
> + the interrupts specified in 'interrupts'
> + property.
> +
> +Example:
> + pmi8998_lsid1: pmic@3 {
> + labibb {
> + compatible = "qcom,pmi8998-lab-ibb";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + lab: lab {
> + interrupts = <0x3 0xde 0x0 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "lab-sc-err";
> + };
> +
> + ibb: ibb {
> + interrupts = <0x3 0xdc 0x2 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "ibb-sc-err";
> + };
> +
> + };
> + };
> --
> 2.26.2
>
