On Sat, May 9, 2020 at 3:47 AM Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Fri, 8 May 2020, Al Cooper wrote: ... > > + irq = platform_get_irq(pdev, 0); > > + if (irq <= 0) > > + return irq; > > I don't want to get involved in the question of whether or not 0 is a > valid IRQ number. The consensus has gone back and forth over the > years, and it just doesn't seem important. > > However, as Sergei points out, if 0 is going to be regarded as an > invalid value then we shouldn't return 0 from the probe function here. The most of the drivers rely on the fact that on platforms where it's the case (yes, we have you-know-which architecture has some legacy stuff there) request_irq() will fail anyway. > I'll leave the decision on how to handle this matter up to Greg. :-) Me too. -- With Best Regards, Andy Shevchenko
