Hi, On Thu, Apr 30, 2020 at 12:46 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > The ti-sn65dsi86 MIPI DSI to eDP bridge chip has 4 pins on it that can > be used as GPIOs in a system. Each pin can be configured as input, > output, or a special function for the bridge chip. These are: > - GPIO1: SUSPEND Input > - GPIO2: DSIA VSYNC > - GPIO3: DSIA HSYNC or VSYNC > - GPIO4: PWM One suggestion that came off-list is to change the code to make the numbering match up better with the datasheet. Right now if you want GPIO 2 you have to refer to it like: hpd-gpios = <&sn65dsi86_bridge 1 GPIO_ACTIVE_HIGH>; That's because the code right now numbers things starting at 0 even if the datasheet numbers things starting at 1. I'm planning to spin the series later today for this. While at it, I'll squash my yaml bindings fixup into the bindings patch in this series. If someone would rather I wait and not spin yet, please yell.