On Tue, 5 May 2020 at 13:16, Anders Roxell <anders.roxell@xxxxxxxxxx> wrote: > > On Tue, 5 May 2020 at 13:05, Grygorii Strashko <grygorii.strashko@xxxxxx> wrote: > > > > hi Anders, > > Hi Grygorii, Hi again, > > > > > On 05/05/2020 13:17, Anders Roxell wrote: > > > On Fri, 1 May 2020 at 22:50, Grygorii Strashko <grygorii.strashko@xxxxxx> wrote: > > >> > > >> The MCU CPSW Common Platform Time Sync (CPTS) provides possibility to > > >> timestamp TX PTP packets and all RX packets. > > >> > > >> This enables corresponding support in TI AM65x/J721E MCU CPSW driver. > > >> > > >> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx> > > >> --- > > >> drivers/net/ethernet/ti/Kconfig | 1 + > > >> drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 24 ++- > > >> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 172 ++++++++++++++++++++ > > >> drivers/net/ethernet/ti/am65-cpsw-nuss.h | 6 +- > > >> 4 files changed, 201 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig > > >> index 1f4e5b6dc686..2c7bd1ccaaec 100644 > > >> --- a/drivers/net/ethernet/ti/Kconfig > > >> +++ b/drivers/net/ethernet/ti/Kconfig > > >> @@ -100,6 +100,7 @@ config TI_K3_AM65_CPSW_NUSS > > >> depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER > > >> select TI_DAVINCI_MDIO > > >> imply PHY_TI_GMII_SEL > > >> + imply TI_AM65_CPTS > > > > > > Should this be TI_K3_AM65_CPTS ? instead of 'imply TI_K3_AM65_CPTS' don't you want to do this: 'depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS' Cheers, Anders > > > > > > I did an arm64 allmodconfig build on todays next tag: next-20200505 > > > and got this undefined symbol: > > > > > > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > > > function `am65_cpsw_init_cpts': > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1685: > > > undefined reference to `am65_cpts_create' > > > aarch64-linux-gnu-ld: > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1685:(.text+0x2e20): > > > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > > > `am65_cpts_create' > > > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > > > function `am65_cpsw_nuss_tx_compl_packets': > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:923: > > > undefined reference to `am65_cpts_tx_timestamp' > > > aarch64-linux-gnu-ld: > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:923:(.text+0x4cf0): > > > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > > > `am65_cpts_tx_timestamp' > > > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > > > function `am65_cpsw_nuss_ndo_slave_xmit': > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1018: > > > undefined reference to `am65_cpts_prep_tx_timestamp' > > > aarch64-linux-gnu-ld: > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1018:(.text+0x58fc): > > > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > > > `am65_cpts_prep_tx_timestamp' > > > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > > > function `am65_cpsw_nuss_hwtstamp_set': > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1265: > > > undefined reference to `am65_cpts_rx_enable' > > > aarch64-linux-gnu-ld: > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1265:(.text+0x7564): > > > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > > > `am65_cpts_rx_enable' > > > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-ethtool.o: in > > > function `am65_cpsw_get_ethtool_ts_info': > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-ethtool.c:713: > > > undefined reference to `am65_cpts_phc_index' > > > aarch64-linux-gnu-ld: > > > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-ethtool.c:713:(.text+0xbe8): > > > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > > > `am65_cpts_phc_index' > > > make[1]: *** [/srv/src/kernel/next/Makefile:1114: vmlinux] Error 1 > > > make[1]: Target 'Image' not remade because of errors. > > > make: *** [Makefile:180: sub-make] Error 2 > > > make: Target 'Image' not remade because of errors. > > > > Sry, I can't reproduce it net-next. > > Oh I forgot to try net-next, sorry. > > > trying next... > > Thank you. > > > What's your config? > > This is the config [1] I used. > > Cheers, > Anders > [1] https://people.linaro.org/~anders.roxell/kernel-next-20200505.config > > > > > -- > > Best regards, > > grygorii
