On 24-04-20, 12:20, Matthias Kaehlcke wrote: > On Fri, Apr 24, 2020 at 06:54:01PM +0300, Georgi Djakov wrote: > > + for (i = 0; i < num_paths; i++) { > > + opp_table->paths[i] = of_icc_get_by_index(dev, i); > > + if (IS_ERR(opp_table->paths[i])) { > > + ret = PTR_ERR(opp_table->paths[i]); > > + if (ret != -EPROBE_DEFER) { > > + dev_err(dev, "%s: Unable to get path%d: %d\n", > > + __func__, i, ret); > > + } > > nit: curly braces not needed Again, braces are preferred across multi-line blocks. Please keep it. -- viresh