Hi Benjamin, On Mon, Apr 20, 2020 at 3:48 PM Benjamin Gaignard <benjamin.gaignard@xxxxxx> wrote: > > Add schemas for firewall consumer and provider. > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx> > +$id: http://devicetree.org/schemas/bus/stm32/firewall-consumer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common Bus Firewall consumer binding > + > +maintainers: > + - Benjamin Gaignard <benjamin.gaignard@xxxxxx> This really needs a description: to tell what is going on and what these firewalls are for and how they are supposed to work. I suppose just a bit of cut'n'paste from the cover letter :D Otherwise it looks good to me. Yours, Linus Walleij