On Tue, May 20, 2014 at 03:49:42PM +0200, Andrew Lunn wrote: > On Tue, May 20, 2014 at 02:34:20PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Tuesday, May 20, 2014 11:04:29 AM Antoine Ténart wrote: > > > > > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > > > index 4906c27fa3bd..b31b1986fda4 100644 > > > --- a/drivers/phy/Kconfig > > > +++ b/drivers/phy/Kconfig > > > @@ -15,6 +15,11 @@ config GENERIC_PHY > > > phy users can obtain reference to the PHY. All the users of this > > > framework should select this config. > > > > > > +config PHY_BERLIN_SATA > > > + bool > > > > Is there any real reason why this cannot be tristate? > > What we have seen with SATA drivers and phys, is there is link time > breakage if the SATA driver is built in and the phy is modular. > > Maybe this has been fixed now? Using tristate shouldn't be a problem. I compiled without the PHY driver, no link issue. Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
