Re: [PATCH v2 2/2] arm64: dts: uniphier: Add support for Akebi96

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yamada-san,

2020年4月21日(火) 21:57 Masahiro Yamada <masahiroy@xxxxxxxxxx>:
>
> On Mon, Apr 20, 2020 at 10:21 PM Masami Hiramatsu
> <masami.hiramatsu@xxxxxxxxxx> wrote:
> > > index f93519793bfb..afa90b762ea9 100644
> > > --- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
> > > +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
> > > @@ -337,7 +337,7 @@ gpio: gpio@55000000 {
> > >                                                      <21 217 3>;
> > >                 };
> > >
> > > -               audio: audio@56000000 {
> > > +               audio@56000000 {
> > >                         compatible = "socionext,uniphier-ld20-aio";
> > >                         reg = <0x56000000 0x80000>;
> > >                         interrupts = <0 144 4>;
> > >
> > >
> > > Lastly, is the pin-setting "aout1", "aout1b" correct ?
> >
> > Yes, according to the schematics of Akebi96(*), it is connected to
> > aout1b(XIRQ*) instead of aout1(AO1*).
> >
> > (*) https://www.96boards.org/documentation/enterprise/akebi96/hardware-docs/akebi96-schematics.pdf
>
> So, I was asking about "aout1", not "aout1b".

Ah, I got it.

>
> According to the schematic, nothing is connected to AO1*.
> See sheet 6.
>
> Why do you need to assign the apparently unused pins?

No, we don't need it. I confirmed we only need groups = "aout1b".
I'll update the series with that fix.

Thank you!

>
>
>
> --
> Best Regards
> Masahiro Yamada



-- 
Masami Hiramatsu




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux