On Thu, Apr 16, 2020 at 03:37:40PM +0100, Robin Murphy wrote: > On 2020-04-16 2:50 pm, Andrew Lunn wrote: > [...] > > Clocking with Marvell devices has always been interesting. Core IP > > like this gets reused between different generations of SoCs. The > > original Orion5x had no clock control at all. Latter SoCs have had > > more and more complex clock trees. So care has to be taken to not > > change old behaviour when adding support for new clocks. > > FWIW, that sounds like a good argument for encoding the clock requirements > of each variant in the of_match_data, so the driver doesn't have to simply > trust the DT and hope. Please read my patches. This is exactly what I'm doing. I'm preserving as closely as possible the current driver behaviour while adding support for the Armada 8040 PWM while keeping compatibility with older DT. And I'm doing that by keying off the match data, exactly as you're suggesting above. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
