On 2020-04-16 2:50 pm, Andrew Lunn wrote: [...]
Clocking with Marvell devices has always been interesting. Core IP like this gets reused between different generations of SoCs. The original Orion5x had no clock control at all. Latter SoCs have had more and more complex clock trees. So care has to be taken to not change old behaviour when adding support for new clocks.
FWIW, that sounds like a good argument for encoding the clock requirements of each variant in the of_match_data, so the driver doesn't have to simply trust the DT and hope.
Robin.
