Hi Michael, this is looking good provided we can get the generic GPIO regmap helper reviewed and merged. Thanks! On Thu, Apr 2, 2020 at 10:37 PM Michael Walle <michael@xxxxxxxx> wrote: > This adds support for the GPIO controller of the sl28 board management > controller. This driver is part of a multi-function device. > > Signed-off-by: Michael Walle <michael@xxxxxxxx> > + depends on MFD_SL28CPLD Apart from this depends it seems the patch is compile-time independent of the other patches so I'd suggest we just merge the generic regmap driver and this driver to the GPIO tree once we feel finished with them, optimistically assuming that the MFD driver will land and that we will not need any fundamental changes in the GPIO driver. Worst case we have to revert the driver and that is no disaster. Yours, Linus Walleij