On Sat, 11 Apr 2020, at 00:29, Alexander A. Filippov wrote:
> On Fri, Apr 10, 2020 at 02:29:47PM +0930, Andrew Jeffery wrote:
> >
> >
> > > +&i2c11 {
> > > + status = "okay";
> > > +};
> > > +
> > > +&i2c12 {
> > > + status = "okay";
> > > +};
> >
> > Are you accessing devices on the busses from userspace? It would
> > be helpful to comment here why you're enabling all of these busses
> > but not describing any devices on them, if it's necessary to enable
> > them at all.
> >
>
> Yes, some of them are unused and may be removed.
> For others I'll add comments in the next version.
>
> > > +
> > > +&adc {
> > > + status = "okay";
> >
> > You should specify the pinmux configuration for the channels you're using
> > to ensure exclusive access to those pins (otherwise they could be exported
> > e.g. as GPIOs).
>
> It was just copied from Romulus and looks like I missed iio-hwmon-battery.
> Is it what you meant?
The Romulus devicetree may need to be fixed too :)
Andrew
