On Wed, Apr 15, 2020 at 07:56:03AM +0800, Chris Ruehl wrote: > This patch add support for Analog Devices (Linear Technology) > LTC2634 Quad 12-/10-/8-Bit Rail-to-Rail DAC. > The SPI functionality based on them from LTC2632 therefor > add the definitions only and update the Kconfig. > > V2: > Send the documentation fix in a extra patch > Kconfig simplify the driver description, details to the help text > ltc2632.txt add to this patch-set (prepare to convert to yaml) > > V3: > Consistens decimal separator in help text The description about how the patch evolves usually goes below the --- and S-o-b area. This way it doesn't make it into the commit history. > > Signed-off-by: Chris Ruehl <chris.ruehl@xxxxxxxxxxxx> > --- > .../devicetree/bindings/iio/dac/ltc2632.txt | 8 ++- > drivers/iio/dac/Kconfig | 6 +- > drivers/iio/dac/ltc2632.c | 60 +++++++++++++++++++ > 3 files changed, 70 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt > index 338c3220f01a..1ab9570cf219 100644 > --- a/Documentation/devicetree/bindings/iio/dac/ltc2632.txt > +++ b/Documentation/devicetree/bindings/iio/dac/ltc2632.txt > @@ -1,4 +1,4 @@ > -Linear Technology LTC2632/2636 DAC > +Linear Technology LTC2632/2634/2636 DAC > > Required properties: > - compatible: Has to contain one of the following: > @@ -8,6 +8,12 @@ Required properties: > lltc,ltc2632-h12 > lltc,ltc2632-h10 > lltc,ltc2632-h8 > + lltc,ltc2634-l12 > + lltc,ltc2634-l10 > + lltc,ltc2634-l8 > + lltc,ltc2634-h12 > + lltc,ltc2634-h10 > + lltc,ltc2634-h8 > lltc,ltc2636-l12 > lltc,ltc2636-l10 > lltc,ltc2636-l8 > diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig > index 93744011b63f..aee13ced6ddf 100644 > --- a/drivers/iio/dac/Kconfig > +++ b/drivers/iio/dac/Kconfig > @@ -279,12 +279,12 @@ config LTC1660 > module will be called ltc1660. > > config LTC2632 > - tristate "Linear Technology LTC2632-12/10/8 and LTC2636-12/10/8 DAC spi driver" > + tristate "Linear Technology LTC2632-12/10/8 and similar DAC spi driver" > depends on SPI > help > Say yes here to build support for Linear Technology > - LTC2632-12, LTC2632-10, LTC2632-8, LTC2636-12, LTC2636-10 and > - LTC2636-8 converters (DAC). > + LTC2632, LTC2634 and LTC2636 DAC resolution 12/10/8 bit > + low 0-2.5V and high 0-4.096V range converters. > The naming pattern seems to be: LTC263ab-cc with: a = 2 -> 2 channels a = 4 -> 4 channels a = 6 -> 8 channels b = L -> Vref = 2.5V b = H -> Vref = 4.096V cc = 8 -> 8 bit precision cc = 10 -> 10 bit precision cc = 12 -> 12 bit precision Would it make sense to document this somewhere? But as this is (somewhat) orthogonal to this patch: Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
