On Fri, Apr 03, 2020 at 12:01:01PM +0300, Stanimir Varbanov wrote: > Hi Ansuel, > > On 4/2/20 3:11 PM, Ansuel Smith wrote: > > From: Sham Muthayyan <smuthayy@xxxxxxxxxxxxxx> > > > > Add Force GEN1 support needed in some ipq806x board > > that needs to limit some pcie line to gen1 for some > > hardware limitation. > > This is set by the max-link-speed dts entry and needed > > by some soc based on ipq806x. (for example Netgear R7800 > > router) > > > > Signed-off-by: Sham Muthayyan <smuthayy@xxxxxxxxxxxxxx> > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> > > --- > > drivers/pci/controller/dwc/pcie-qcom.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > index 8047ac7dc8c7..2212e9498b91 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > @@ -27,6 +27,7 @@ > > #include <linux/slab.h> > > #include <linux/types.h> > > > > +#include "../../pci.h" > > This looks suspiciously (even ugly), but I saw that the other users of > of_pci_get_max_link_speed is doing the same. > > Bjorn H. : do you know why the prototype is there? Perhaps it must be in > linux/of_pci.h. No, because the function should not be used outside of drivers/pci/. Rob
